Re-work logging and command-line argument parsing #3980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
requested changes
Jun 9, 2023
Michael-F-Bryan
changed the title
$RUST_LOG variable is set
Michael-F-Bryan
force-pushed
the
disable-logging-by-default
branch
from
7fe964d to
4f0438c
Compare
theduke
approved these changes
Jun 15, 2023
Michael-F-Bryan
force-pushed
the
disable-logging-by-default
branch
from
ded7c54 to
c923745
Compare
syrusakbary
approved these changes
Jun 15, 2023
|
@syrusakbary most of the For example, wasmer/tests/integration/cli/tests/run.rs Lines 339 to 354 in 2b867fa |
Michael-F-Bryan
force-pushed
the
disable-logging-by-default
branch
from
c923745 to
4a0b438
Compare
Michael-F-Bryan
force-pushed
the
disable-logging-by-default
branch
2 times, most recently
from
4b7c86d to
e3abe19
Compare
added 10 commits
June 16, 2023 23:07
Michael-F-Bryan
force-pushed
the
disable-logging-by-default
branch
from
e3abe19 to
e620278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When discussing #3948, we decided that the
wasmercommand shouldn't show any log messages unless the user explicitly sets the$RUST_LOGenvironment variable. That way there's no chance that logging will mess up the output you might get from a program.I've also re-worked the CLI parsing code to be vanilla clap rather than having a mix of manual argument parsing and two different clap parsers. This means we no longer need to update that big
matchstatement every time a new command or alias is added, plus it makes the code a lot more readable.Fixes #3948.